mirror of
https://github.com/RGBCube/serenity
synced 2025-10-13 18:32:06 +00:00
f562c470e2
Previously, if we wanted to to e.g. do linear interpolation in 2-D,
we'd get a sample point like (1.3, 4.4), then get 4 samples around
it at (1, 4), (2, 4), (1, 5), (2, 5), then reduce the 4 samples
to 2 samples by computing the combined samples
`0.3 * f(1, 4) + 0.7 * f(2, 4)` and `0.3 * f(1, 5) + 0.8 * f(2, 5)`,
and then 1-D linearly blending between these two samples with the
factor 0.4. In the end we'd multiply the first value by 0.3 * 0.4,
the second by 0.7 * 0.4, the third by 0.3 * 0.6, and the third by
0.7 * 0.6, and then sum them all up.
This requires computing and storing 2**N samples, followed by
another 2**N iterations to combine the 2**N sampls to a single value.
(N is in practice either 4 or 3, so 2**N isn't super huge.)
Instead, for every sample we can directly compute the product of
weights and sum them up directly. This lets us omit the second loop
and storing 2**N values, in exchange for doing an additional O(n)
work to compute the product.
Takes
Build/lagom/bin/image --no-output --invert-cmyk \
--assign-color-profile \
Build/lagom/Root/res/icc/Adobe/CMYK/USWebCoatedSWOP.icc \
--convert-to-color-profile serenity-sRGB.icc \
cmyk.jpg
form 3.42s to 3.08s on my machine, almost 10% faster (and less code).
Here cmyk.jpg is a 2253x3080 cmyk jpeg, and USWebCoatedSWOP.icc is an
mft2 profile with input tables with 256 samples and a 9x9x9x9 CLUT.
The LibPDF change is covered by TEST_CASE(sampled) in LibPDF.cpp,
and the LibGfx change is basically the same change as the one in
LibPDF (where the test results don't change) and the output
subjectively looks identical. So hopefully this causes indeed no
behavior change :^)
|
||
|---|---|---|
| .. | ||
| Fonts | ||
| CMakeLists.txt | ||
| ColorSpace.cpp | ||
| ColorSpace.h | ||
| CommonNames.cpp | ||
| CommonNames.h | ||
| Document.cpp | ||
| Document.h | ||
| DocumentParser.cpp | ||
| DocumentParser.h | ||
| Encoding.cpp | ||
| Encoding.h | ||
| Encryption.cpp | ||
| Encryption.h | ||
| Error.h | ||
| Filter.cpp | ||
| Filter.h | ||
| Forward.h | ||
| Function.cpp | ||
| Function.h | ||
| Interpolation.cpp | ||
| Interpolation.h | ||
| Object.h | ||
| ObjectDerivatives.cpp | ||
| ObjectDerivatives.h | ||
| Operator.h | ||
| Page.cpp | ||
| Page.h | ||
| Parser.cpp | ||
| Parser.h | ||
| Reader.cpp | ||
| Reader.h | ||
| Reference.h | ||
| Renderer.cpp | ||
| Renderer.h | ||
| Value.cpp | ||
| Value.h | ||
| XRefTable.h | ||