RGBCube/uutils-coreutils
1
Fork 0
mirror of https://github.com/RGBCube/uutils-coreutils synced 2025-08-04 15:07:47 +00:00
Code Issues Activity

refactor/polish ~ fix cargo clippy complaints (&Vec => &[])

Browse source
This commit is contained in:
Roy Ivy III 2019-12-26 15:22:08 -06:00
parent a72422fb0e
commit ea8ed8d5da
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/numfmt/numfmt.rs
View file

@ -257,7 +257,7 @@ fn parse_options(args: &Matches) -> Result<NumfmtOptions> {
}) })
} }
fn handle_args(args: &Vec<String>, options: NumfmtOptions) -> Result<()> { fn handle_args(args: &[String], options: NumfmtOptions) -> Result<()> {
for l in args { for l in args {
println!("{}", format_string(l.clone(), &options)?) println!("{}", format_string(l.clone(), &options)?)
} }

2
src/od/parse_formats.rs
View file

@ -100,7 +100,7 @@ fn od_argument_with_option(ch: char) -> bool {
/// arguments with parameters like -w16 can only appear at the end: -fvoxw16 /// arguments with parameters like -w16 can only appear at the end: -fvoxw16
/// parameters of -t/--format specify 1 or more formats. /// parameters of -t/--format specify 1 or more formats.
/// if -- appears on the commandline, parsing should stop. /// if -- appears on the commandline, parsing should stop.
pub fn parse_format_flags(args: &Vec<String>) -> Result<Vec<ParsedFormatterItemInfo>, String> { pub fn parse_format_flags(args: &[String]) -> Result<Vec<ParsedFormatterItemInfo>, String> {
let mut formats = Vec::new(); let mut formats = Vec::new();
// args[0] is the name of the binary // args[0] is the name of the binary

10
src/printf/tokenize/num_format/formatters/base_conv/mod.rs
View file

@ -1,4 +1,4 @@
pub fn arrnum_int_mult(arr_num: &Vec<u8>, basenum: u8, base_ten_int_fact: u8) -> Vec<u8> { pub fn arrnum_int_mult(arr_num: &[u8], basenum: u8, base_ten_int_fact: u8) -> Vec<u8> {
let mut carry: u16 = 0; let mut carry: u16 = 0;
let mut rem: u16; let mut rem: u16;
let mut new_amount: u16; let mut new_amount: u16;
@ -164,8 +164,8 @@ pub fn arrnum_int_div_step<'a>(
// ArrFloatDivOut { quotient: quotient, remainder: remainder } // ArrFloatDivOut { quotient: quotient, remainder: remainder }
// } // }
// //
pub fn arrnum_int_add(arrnum: &Vec<u8>, basenum: u8, base_ten_int_term: u8) -> Vec<u8> { pub fn arrnum_int_add(arrnum: &[u8], basenum: u8, base_ten_int_term: u8) -> Vec<u8> {
let mut carry: u16 = base_ten_int_term as u16; let mut carry: u16 = u16::from(base_ten_int_term);
let mut rem: u16; let mut rem: u16;
let mut new_amount: u16; let mut new_amount: u16;
let base: u16 = basenum as u16; let base: u16 = basenum as u16;
@ -218,7 +218,7 @@ pub fn unsigned_to_arrnum(src: u16) -> Vec<u8> {
// temporary needs-improvement-function // temporary needs-improvement-function
#[allow(unused_variables)] #[allow(unused_variables)]
pub fn base_conv_float(src: &Vec<u8>, radix_src: u8, radix_dest: u8) -> f64 { pub fn base_conv_float(src: &[u8], radix_src: u8, radix_dest: u8) -> f64 {
// it would require a lot of addl code // it would require a lot of addl code
// to implement this for arbitrary string input. // to implement this for arbitrary string input.
// until then, the below operates as an outline // until then, the below operates as an outline
@ -253,7 +253,7 @@ pub fn str_to_arrnum(src: &str, radix_def_src: &dyn RadixDef) -> Vec<u8> {
intermed_in intermed_in
} }
pub fn arrnum_to_str(src: &Vec<u8>, radix_def_dest: &dyn RadixDef) -> String { pub fn arrnum_to_str(src: &[u8], radix_def_dest: &dyn RadixDef) -> String {
let mut str_out = String::new(); let mut str_out = String::new();
for u in src.iter() { for u in src.iter() {
match radix_def_dest.from_u8(u.clone()) { match radix_def_dest.from_u8(u.clone()) {