mirror of
https://github.com/RGBCube/serenity
synced 2026-01-12 22:41:00 +00:00
990e7219d6
After finishing layout, iframe layout boxes (FrameBox) get notified about their new size by LayoutState::commit(). This information is forwarded to the nested browsing context, where it can be used for layout of the nested document. The problem here was that we notified the FrameBox twice. Once when assigning the used offset to its paintable, and once when assigning its size. Because the offset was assigned first, we ended up telling the FrameBox "btw, your size is 0x0". This caused us to throw away all the layout information we had for the nested document. We'd then say "actually, your size is 300x200" (or something) but by then it was already too late, and we had to do a full relayout. This caused iframes to flicker as every time their containing document was laid out, we'd nuke the iframe layout and redo it (on a zero timer). The fix is pleasantly simple: we didn't need to inform the nested document of its offset in the containing document's layout anyway. Only its size is relevant. So we can simply remove the first call, which removes the bogus 0x0 temporary size. Note that iframes may still flicker if they change size in the containing document. That's a separate issue that will require more finesse to solve. However, this fixes a very noticeable common case. |
||
|---|---|---|
| .. | ||
| Applets | ||
| Applications | ||
| BuggieBox | ||
| Demos | ||
| DevTools | ||
| DynamicLoader | ||
| Games | ||
| Libraries | ||
| Services | ||
| Shell | ||
| Utilities | ||
| CMakeLists.txt | ||